Skip to content

Allow cleaning up of networks stuck in Implementing state #12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Pearl1594 wants to merge 1 commit into
base: 4.20
Choose a base branch
from
Draft

Allow cleaning up of networks stuck in Implementing state #12409

Pearl1594 wants to merge 1 commit into from
+75 −0

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Jan 12, 2026

Description

This PR fixes: #12249
This PR allows cleanup of Networks that have been stuck in Implementing state for more than the job.expire.minutes setting and has no async jobs associated.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. Created a network
  2. Created a VM in that network and cleaned up the VM
  3. Set network (manually in DB) to Implementing state
  4. Observe logs (temporarily placed one of the trace logs in the code as debug)
...
Found 1 networks in Implementing state, checking for orphaned networks
2026-01-12 16:43:58,432 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:[ctx-abe618b0]) (logid:5ee73b3f) Network 204 in Implementing state is only 9 minutes old (threshold: 10 minutes), skipping cleanup
..
 Found 1 networks in Implementing state, checking for orphaned networks
2026-01-12 16:44:08,434 WARN  [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:[ctx-5012868f]) (logid:8c11718f) Found orphaned network 204 in Implementing state without async job. Network created: 2026-01-12T16:34:05.000+0000, age: 10 minutes, expiration threshold: 10 minutes. Transitioning to Shutdown state.

...
<img width="1621" height="147" alt="image" src="https://github.com/user-attachments/assets/8aadf16e-c022-4502-b88f-7c090a18e5f3" />

Moves network to Shutdown state and from there the networks can be deleted.

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.33%. Comparing base (4348386) to head (bfbb8bb).
⚠️ Report is 30 commits behind head on 4.20.

Files with missing lines Patch % Lines
...stack/framework/jobs/impl/AsyncJobManagerImpl.java 0.00% 54 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #12409      +/-   ##
============================================
+ Coverage     16.21%   16.33%   +0.11%     
- Complexity    13353    13685     +332     
============================================
  Files          5657     5657              
  Lines        498647   506311    +7664     
  Branches      60533    63554    +3021     
============================================
+ Hits          80863    82701    +1838     
- Misses       408771   414434    +5663     
- Partials       9013     9176     +163
Flag Coverage Δ
uitests 4.08% <ø> (+0.07%) ⬆️
unittests 17.18% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 12, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

DaanHoogland
DaanHoogland reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpit, I would disect cleanupOrphanedNetworks() further as well.

framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
Comment on lines +973 to +978
// 3) Cleanup orphaned networks stuck in Implementing state without async jobs
try {
cleanupOrphanedNetworks();
} catch (Throwable e) {
logger.error("Unexpected exception when trying to cleanup orphaned networks", e);
}
Copy link
Contributor

@DaanHoogland DaanHoogland Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a try catch as highest level inside cleanupOrphanedNetworks(), is this one needed?

Copy link
Contributor Author

@Pearl1594 Pearl1594 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following how the other cases are handled. Also, we will be able to know which operation really failed in this block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pearl1594 @DaanHoogland